CBSubs off line gateway keeps proforma invoice number when paid

Hello

I have noticed that using CBsubs offline gateway with Proforma invoice number set will keep the proforma invoice number when the payment has been made.

Process is :
New basket using offline gateway
Confirm slip
Record the payment just after issuing slip

It is needed that the invoice implementation should be kept even with offline gateway and that the definitive invoice number is also implemented once the payment is made

Mind to check on your install ?

thanks
Jean

I was not able to confirm. Within the database table _cbsubs_payment_baskets the column invoice has the correct invoice number with the proforma being moved to proformainvoice column. Did you completely pay the basket or just partially? Can you verify the invoice columns in the _cbsubs_payment_baskets to be sure it didn't update them?

Ok I see what's wrong. We use the table _cbsubs_payment and not the table _cbsubs_payment_baskets to get a query request of all payments and invoice numbers as we cannot do it with _cbsubs_payment_baskets

In table _cbsubs_payment the invoice number stays the pro forma number and does not update to the final invoicing scheme.

Is that normal behavior for offline payments ?

_cbsubs_payment is supposed to indicate the invoice it paid in this case the invoice was proforma at that time. I've confirmed both Offline and the Dummy gateways are storing the proforma to _cbsubs_payment. So I believe it's working fine. Invoice = Basket so you should be pulling it from _cbsubs_payment_baskets if you want it to be reliable.

Invoice = Basket so you should be pulling it from _cbsubs_payment_baskets if you want it to be reliable.

Mmmm that brings us back to the recurring payments problem with only one invoice. That's the reason why we use the payment table to check everything

Of course once your modifications are made according to the other post, everything should be ok but until now we have no other solution

Were you seeing different behavior with other payment methods? I'm not seeing where in the code it'd decide to log a different invoice number than the one currently stored with the basket at time of payment row storage as payment rows don't have the functionality to generate an invoice number (it just grabs it from the basket object). If you are seeing different behavior then it's likely the invoice number already transitioned from proforma before the payment row was stored.