[SOLVED] in CBSubs with special promotion a bug makes password saved in plain text on registration

krileon wrote: Please PM backend login credentials...

Done - sent to both Beat and yourself.
I've also been recalling my earlier message to Beat since he had not read it yet, and to reduce the "load" on him.

Anyway, it's my clean test environment, as described before with only J! 3.5.1, CB, CBSubs (and Akeeba Backup), nothing else. And the issue persists.

You can do whatever you want with it, afterwards I'll delete it anyway.

Thanks!

Have reviewed your install. It's a strange combination of configurations causing this.

First your plan is free 1 day duration (suspect duration is insignificant). Second you have "Allow Free Registered Users (without subscriptions)" set to "No". Third you've a promotion increasing the price of the free plan to charge postage.

This trifecta is what is causing it. Once "Allow Free Registered Users (without subscriptions)" is set to "Yes" OR the promotion is removed the problem is gone.

Now that I know how to reliably reproduce this I've updated the ticket with the steps and set its priority to immediate as well as informed Beat of my findings so he can investigate further to fix.

With that said either of the above adjustments will workaround your issue for the time being. You can see my findings on the Passwords userlist where half of the demo users confirm the issue and the other half confirm the workaround.

Ok, found the exact cause. Quickfix is as follows.

IN: components/com_comprofiler/plugin/user/plug_cbpaidsubscriptions/cbpaidsubscriptions.php
ON: Lines 579 - 580
FROM: TO:
User stores during registration can be.. iffy.. so they need to null the password before doing so then revert the null to avoid their storage. We need to improve user store to prevent this from ever happening again somehow in CB it self (we do have functions for this, but CBSubs isn't using them at this time), but the above will fix it and will have fixed for next release.

(deleted)

Issue is fixed. See my most recent reply . You won't have to change any of your settings.

krileon wrote: Ok, found the exact cause. Quickfix is as follows.

Hey Kyle,

Just did some testing, and indeed: that fixes it!

Pheeew, glad that's sorted. Thanks a ton for your jumping in!

Bingo - case closed. Trust it'll make it into the next nightly.

Thanks again!