If we use onCPayAfterPaymentStatusUpdateEvent, what is the best global status to use ?
For the renumbering? You don't even need to bother checking status. Just let it renumber anytime that event is called
So how can we avoid to have three times the auto action running for the manual gateways and wrongly implemented payment invoice numbers ?
It can't wrongly renumber them as it clears the number and renumbers each call. I'm not 100% sure the SET variable will even work in a Query action so be sure to test carefully.
Also I have noticed that the invoice output only displays the [user_id] of the mod and not the one of the user.
That's due to $user being passed. Try the below.
Code:
// First lets try to find and load the payment:
$payment = new cbpaidPayment();
$payment->load( (int) '[get_payment]' );
$isOwner = ( (int) $payment->get( 'by_user_id' ) == (int) '[user_id]' );
if ( ( ! $isOwner ) && ( ! \CBLib\Application\Application::User( (int) '[user_id]' )->isGlobalModerator() ) ) {
return null;
}
// Now we need the original basket for the payment:
$paymentBasket = new cbpaidPaymentBasket();
$paymentBasket->load( (int) $payment->get( 'payment_basket_id' ) );
$paymentUser = CBuser::getUserDataInstance( (int) $paymentBasket->get( 'user_id' ) );
// Finally we'll override some of the values of the basket so the basket invoice reflects the most recent payment:
$paymentBasket->set( 'time_initiated', $payment->get( 'time_created' ) );
$paymentBasket->set( 'time_updated', $payment->get( 'time_modified' ) );
$paymentBasket->set( 'time_completed', $payment->get( 'time_paid' ) );
$paymentBasket->set( 'time_completed_date', $payment->get( 'time_paid_date' ) );
$paymentBasket->set( 'time_completed_day_of_week', $payment->get( 'time_paid_day_of_week' ) );
$paymentBasket->set( 'time_completed_yearweek', $payment->get( 'time_paid_yearweek' ) );
$paymentBasket->set( 'time_completed_yearmonth', $payment->get( 'time_paid_yearmonth' ) );
$paymentBasket->set( 'time_completed_hour', $payment->get( 'time_paid_hour' ) );
$paymentBasket->set( 'proformainvoice', $payment->get( 'invoice' ) );
return $paymentBasket->displayInvoice( $paymentUser, $isOwner, false );
krileon
