Krileon,
Given that I am not a PHP programmer and am not familiar with what the code in question does, I am hesitant to just edit it out without trying to understand what other problems this might cause (besides the obvious one that I will have to keep track of the hacks in order to re-hack them after a future upgrade "un-hacks" them).
But I did take a look at the code and found that on the CB side, it looks like the code isn't needed, given that I am on CB 1.3.1:
Code:
/**
* @deprecated CB 1.2.2 (not used at all in CB and CB Team plugins after CB 1.2.2, so can be removed)
* Legacy function: use CBTxt::html_entity_decode( $string ) instead !
*/
function unhtmlentities( $string, $quotes = ENT_COMPAT, $charset = "ISO-8859-1" ) {
return CBTxt::_unhtmlentities( $string, $quotes, $charset );
}
So it looks like I can just extend the comment around the function definition?
On the Smartformer side, the code that is conflicting is:
Code:
function unhtmlentities($string)
{
$trans_tbl = get_html_translation_table(HTML_ENTITIES);
$trans_tbl = array_flip($trans_tbl);
return strtr($string, $trans_tbl);
}
Thanks
krileon
