[#8917] No alert message when logging out from menu item.

If a user logs out from the CB module, they are taken to the home page and an alert saying "You have successfully logged out" appears in the <jdoc:include type="message" /> area.

But if they log out from a menu item - it doesn't matter if it is a new CB logout menu item, or an alias to the logout in the CB default menu - they don't get the confirmation that they logged out. They are taken to the homepage, so at least that works.

Any idea why the discrepancy? I would love for this to be consistent.

No idea, both login module and logout menu items go to the same logout URL where the message is sent to Joomla's redirect function. Joomla message queue is entirely responsible for persisting that message across pages and rendering it. My guess is it's lost when the login session is deleted. We don't really have a way around this as we already set the message into the message queue as late as possible.

This is apparently a bug?

In the file comprofiler.php line 1307 reads:
$message = trim( cbGetParam( $_POST, 'message', 0 ) );

I changed it to:
$message = trim( cbGetParam( $_POST, 'message', 1 ) );

And now the alert shows just fine when logging out using the CB User Logout menu type. It also fixed a few other alerts that were not showing when using menu items.

I can't see why such a change would matter. The 3rd parameter just sets the default value if the data doesn't exist in POST. So if it doesn't exist it's just set to 1 instead of 0. The default probably shouldn't even be 0 but '' (empty string) or nothing for NULL.

Ok, I see why it's doing this. It's expecting message to come from POST which it won't if the logout URL is directly accessed and is why the logout message isn't passed to the redirect. Will review changing this behavior when accessing the logout URL directly.

forge.joomlapolis.com/issues/8917