[SOLVED] Is there a "proper" way of adding to a user profile from a form?

Don't understand the issue. You're using myId so it's always going to update the user that is filling out the form.

Not sure what myld meens?
The reason for the check is that an existing clubmember can help out a new clubmember with the form, by logging himself in at the site, and filling out the form for the other guy, this way, the logged in user is not the same as the member signing up for the club.
To make sure that the currently logged in user is not updated with the new members info, that should be checked I think.

myId is the ID of the user viewing the page, basically the person logged in. It's their user id.

Your form is not designed for someone else to edit it. It will always load and save the user object of the user viewing the form (the user logged in).

The form gets the values pushed from hidden fields on the confirmation page, so that part should be ok, I think I'll test it out a bit more...

You're using the following.

$myId = $_CB_framework->myId();
$user =& CBuser::getUserDataInstance( $myId );

The $user that you're editing and saving is always the user performing the edit. You can't edit other users like this without passing the other users ID instead of $myId. Basically with this code you're always editing your self.

Quite right, so if I compare the email address given in the form (entered by hand by the user signing up) with the current users email, I will know if it's the same user, right?
The currently logged in users email I get with $juser->email and the email given in the form I get with $form->