Skip to Content Skip to Menu

🎃 Happy Halloween! Treat yourself with an awesome discount on memberships! Get 20% off now with code SPOOKY-2024!

Conceptual error in string coding.

  • MadPax
  • MadPax
  • OFFLINE
  • Posts: 17
  • Thanks: 1
  • Karma: 3
11 years 2 months ago #233063 by MadPax
Conceptual error in string coding. was created by MadPax
Please check the following in file:

/components/com_comprofiler/plugin/user/plug_cbgroupjive/plugins/cbgroupjiveevents/cbgroupjiveevents.php


In lines 213 and 566 where it says:
Code:
. ( $canNotAttend ? '<div><a href="javascript: void(0);" onclick="' . cbgjClass::getPluginURL( array( 'plugin', 'events_no', (int) $category->get( 'id' ), (int) $group->get( 'id' ), (int) $row->get( 'id' ) ), CBTxt::T( 'Are you sure you do not want to attend this event?' ), true, false, null, true ) . '"><i class="icon-thumbs-down"></i> ' . CBTxt::Th( 'Not Attending' ) . '</a></div>' : null )
in particular the
Code:
CBTxt::Th( 'Not Attending' )
bit

It should read 'Not attend' (first person singular as in I will not attend) because it may get overlapped/confused with other 'Not Attending'
Where the meaning is: a certain number of users is not attending (3rd person plural).

Language files should be updated accordingly. (integrations_language.php)

This problem never comes up in languages where the verb attending is the same for both these conjugations.

Please update in upcoming versions,
Thanks
Peter

Please Log in or Create an account to join the conversation.

  • krileon
  • krileon
  • ONLINE
  • Posts: 48466
  • Thanks: 8280
  • Karma: 1443
11 years 2 months ago - 11 years 2 months ago #233106 by krileon
Replied by krileon on topic Conceptual error in string coding.
It's not cut and dry plural/singular case. It depends on the context as adjectives, verbs, nouns, with and without object references can alter the meaning entirely. It's used in the manner of "I will not be attending this event" or "I am not attending this event". In both cases "attend" does not make sense. It's probably better to change it to a cut and dry "Yes", "Maybe", and "No" to simplify it and avoid confusion. You're welcome to edit it to whatever you like directly in your template files though.


Kyle (Krileon)
Community Builder Team Member
Before posting on forums: Read FAQ thoroughly + Read our Documentation + Search the forums
CB links: Documentation - Localization - CB Quickstart - CB Paid Subscriptions - Add-Ons - Forge
--
If you are a Professional, Developer, or CB Paid Subscriptions subscriber and have a support issue please always post in your respective support forums for best results!
--
If I've missed your support post with a delay of 3 days or greater and are a Professional, Developer, or CBSubs subscriber please send me a private message with your thread and will reply when possible!
--
Please note I am available Monday - Friday from 8:00 AM CST to 4:00 PM CST. I am away on weekends (Saturday and Sunday) and if I've missed your post on or before a weekend after business hours please wait for the next following business day (Monday) and will get to your issue as soon as possible, thank you.
--
My role here is to provide guidance and assistance. I cannot provide custom code for each custom requirement. Please do not inquire me about custom development.
Last edit: 11 years 2 months ago by krileon.

Please Log in or Create an account to join the conversation.

  • MadPax
  • MadPax
  • OFFLINE
  • Posts: 17
  • Thanks: 1
  • Karma: 3
11 years 1 month ago #233423 by MadPax
Replied by MadPax on topic Conceptual error in string coding.
Thanks Kyle,

I was just suggesting for you guys to change it for the following versions. I wouldn't really be suggesting it if CB had a way to have overriden string variables as in the base Joomla. The way it's implemented means that any changes I do to CB with an upgrade will make me loose the new strings I put averywhere. But hey, I understand that it would be a huge overhaul to change the way language strings work with CB.

Regards,
Peter.

Please Log in or Create an account to join the conversation.

  • krileon
  • krileon
  • ONLINE
  • Posts: 48466
  • Thanks: 8280
  • Karma: 1443
11 years 1 month ago #233447 by krileon
Replied by krileon on topic Conceptual error in string coding.
We'll be upgrading our language string API in CB 2.0 so we can have plugin specific, location specific, etc.. language strings. This way for example you could have a language string specific to the events integration. That's the plan at least.

As for losing your changes that won't be an issue with next GJ release as all the integrations frontend displays will be GJ template files, which means you can create a new GJ template folder with just the Event integrations template file, make your changes, select it as your template, and it'll load in from the default template whatever is missing. Basically template overrides.


Kyle (Krileon)
Community Builder Team Member
Before posting on forums: Read FAQ thoroughly + Read our Documentation + Search the forums
CB links: Documentation - Localization - CB Quickstart - CB Paid Subscriptions - Add-Ons - Forge
--
If you are a Professional, Developer, or CB Paid Subscriptions subscriber and have a support issue please always post in your respective support forums for best results!
--
If I've missed your support post with a delay of 3 days or greater and are a Professional, Developer, or CBSubs subscriber please send me a private message with your thread and will reply when possible!
--
Please note I am available Monday - Friday from 8:00 AM CST to 4:00 PM CST. I am away on weekends (Saturday and Sunday) and if I've missed your post on or before a weekend after business hours please wait for the next following business day (Monday) and will get to your issue as soon as possible, thank you.
--
My role here is to provide guidance and assistance. I cannot provide custom code for each custom requirement. Please do not inquire me about custom development.

Please Log in or Create an account to join the conversation.

Moderators: beatnantkrileon
Powered by Kunena Forum