[SOLVED] i think i found a bug on the autoaction plugin

edmundcheong
OFFLINE
Posts: 313
Thanks: 10
Karma: 1

11 years 1 week ago - 11 years 6 days ago #235732 by edmundcheong

[SOLVED] i think i found a bug on the autoaction plugin was created by edmundcheong

Each time when you add a new condition, one of the fields go blank or the condition is shifted up.. meaning some of it (conditional fields) disappears when you add a new condition..

Last edit: 11 years 6 days ago by krileon.

Please Log in or Create an account to join the conversation.

krileon
ONLINE
Posts: 48473
Thanks: 8281
Karma: 1443

11 years 1 week ago #235748 by krileon

Replied by krileon on topic i think i found a bug on the autoaction plugin

Can not confirm your issue. Appears to be working perfectly fine. Please ensure you're using latest release 5.1.3. If already using latest and issue persists please provide a screen shot of before and after the issue appears so I can better understand what's happening.

Kyle (Krileon)
Community Builder Team Member
Before posting on forums: Read FAQ thoroughly + Read our Documentation + Search the forums
CB links: Documentation - Localization - CB Quickstart - CB Paid Subscriptions - Add-Ons - Forge
--
If you are a Professional, Developer, or CB Paid Subscriptions subscriber and have a support issue please always post in your respective support forums for best results!
--
If I've missed your support post with a delay of 3 days or greater and are a Professional, Developer, or CBSubs subscriber please send me a private message with your thread and will reply when possible!
--
Please note I am available Monday - Friday from 8:00 AM CST to 4:00 PM CST. I am away on weekends (Saturday and Sunday) and if I've missed your post on or before a weekend after business hours please wait for the next following business day (Monday) and will get to your issue as soon as possible, thank you.
--
My role here is to provide guidance and assistance. I cannot provide custom code for each custom requirement. Please do not inquire me about custom development.

Please Log in or Create an account to join the conversation.

edmundcheong
OFFLINE
Posts: 313
Thanks: 10
Karma: 1

11 years 1 week ago - 11 years 1 week ago #235814 by edmundcheong

Replied by edmundcheong on topic i think i found a bug on the autoaction plugin

I am using version 5.1.3, the previous version is working fine.

What happen is when i create the auto action, i have put in some conditions.. for example below.. I have 3 conditions..

but when i save, the condition disappears for the 2nd and 3rd condition.. see below:

this happens when you add a condition as well.. but what i notice is that when that happens, the value of the condition moves up one.. meaning that condition value no. 2, goes to condition value no. 1.. you can see that in the image below..

BEFORE UPDATE

AFTER UPDATE

if you realise in the second scenario, value for cb_ips142 has gone to cb_ehrusertype..

Attachments:

Last edit: 11 years 1 week ago by edmundcheong.

Please Log in or Create an account to join the conversation.

krileon
ONLINE
Posts: 48473
Thanks: 8281
Karma: 1443

11 years 6 days ago #235831 by krileon

Replied by krileon on topic i think i found a bug on the autoaction plugin

Aha, thank you very much. Yes this indeed is a bug. Looks like the ID for the Value and Translate inputs isn't being added properly so it's causing the increment to break for those 2 inputs. Please apply the below quickfix and it should resolve your issue.

IN: /components/com_comprofiler/plugin/user/plug_cbautoactions/admin.cbautoactions.php
ON: Lines 915 - 916
FROM:

Code:

			$input["value$i"]		=	'<input type="text" id="values__' . $i . '" name="values[value' . $i . ']" value="' . htmlspecialchars( cbautoactionsClass::getHTMLCleanParam( "value$i", null, $row->get( 'value' ) ) ) . '" class="inputbox' . ( in_array( $operator, array( 6, 7 ) ) ? ' cbautoactionsHide' : null ) . '" size="25" />';
			$input["translate$i"]	=	'<input type="checkbox" id="translates__' . $i . '" name="translates[translate' . $i . ']" value="1" class="inputbox"' . ( cbautoactionsClass::getCleanParam( "translate$i", null, $row->get( 'translate' ) ) ? ' checked="checked"' : null ) . ' title="' . htmlspecialchars( CBTxt::T( 'Click to disable translations for this conditional.' ) ) . '" />';

TO:

Code:

			$input["value$i"]		=	'<input type="text" id="values__value' . $i . '" name="values[value' . $i . ']" value="' . htmlspecialchars( cbautoactionsClass::getHTMLCleanParam( "value$i", null, $row->get( 'value' ) ) ) . '" class="inputbox' . ( in_array( $operator, array( 6, 7 ) ) ? ' cbautoactionsHide' : null ) . '" size="25" />';
			$input["translate$i"]	=	'<input type="checkbox" id="translates__translate' . $i . '" name="translates[translate' . $i . ']" value="1" class="inputbox"' . ( cbautoactionsClass::getCleanParam( "translate$i", null, $row->get( 'translate' ) ) ? ' checked="checked"' : null ) . ' title="' . htmlspecialchars( CBTxt::T( 'Click to disable translations for this conditional.' ) ) . '" />';

The following user(s) said Thank You: edmundcheong

Please Log in or Create an account to join the conversation.

edmundcheong
OFFLINE
Posts: 313
Thanks: 10
Karma: 1

11 years 6 days ago #235842 by edmundcheong

Replied by edmundcheong on topic i think i found a bug on the autoaction plugin

I am glad to be able to be part of CB's improvement!! :woohoo:

Thanks for the quick fix!

The following user(s) said Thank You: nant, krileon

Please Log in or Create an account to join the conversation.

Moderators: beat, nant, krileon