Line 887 in cbpaidControllerUI, move div to template

GUEST

8 years 5 months ago - 8 years 5 months ago #281404 by

Line 887 in cbpaidControllerUI, move div to template was created by

Hi!

There's a wrapping div on line 887, file cbpaidControllerUI.php (CBSubs). Could you please move this to the template file instead? That would be templates/default/userupgradeplans/default.php.

TIA
LimeSurvey

Last edit: 8 years 5 months ago by .

Please Log in or Create an account to join the conversation.

krileon
ONLINE
Posts: 48459
Thanks: 8280
Karma: 1443

8 years 5 months ago #281419 by krileon

Replied by krileon on topic Line 887 in cbpaidControllerUI, move div to template

Why does it need to be moved? We'd need to verify all locations the function is being used and retest/redo all of their outputs. That's a lot of work and regression testing. I recommend just not applying any styling to that DIV and wrap your template in your own DIV and should be effectively the same.

Kyle (Krileon)
Community Builder Team Member
Before posting on forums: Read FAQ thoroughly + Read our Documentation + Search the forums
CB links: Documentation - Localization - CB Quickstart - CB Paid Subscriptions - Add-Ons - Forge
--
If you are a Professional, Developer, or CB Paid Subscriptions subscriber and have a support issue please always post in your respective support forums for best results!
--
If I've missed your support post with a delay of 3 days or greater and are a Professional, Developer, or CBSubs subscriber please send me a private message with your thread and will reply when possible!
--
Please note I am available Monday - Friday from 8:00 AM CST to 4:00 PM CST. I am away on weekends (Saturday and Sunday) and if I've missed your post on or before a weekend after business hours please wait for the next following business day (Monday) and will get to your issue as soon as possible, thank you.
--
My role here is to provide guidance and assistance. I cannot provide custom code for each custom requirement. Please do not inquire me about custom development.

Please Log in or Create an account to join the conversation.

GUEST

8 years 5 months ago - 8 years 5 months ago #281443 by

Replied by on topic Line 887 in cbpaidControllerUI, move div to template

Our use-case is to apply UIKit panels, which won't work if there's a div "between" parent and child. Line 887 inserts an extra div we can't change with the template system.

Our wrapping div has class "uk-grid", the plan children "uk-width-1-4". The styling will fail when div with class "cbregPlansList" is put between them.

Edit: One possible solution is to unwrap this div in Javascript. But again, if you really want your plugin to be customizable, there shouldn't be any HTML in the PHP classes.

Last edit: 8 years 5 months ago by .

Please Log in or Create an account to join the conversation.

krileon
ONLINE
Posts: 48459
Thanks: 8280
Karma: 1443

8 years 5 months ago #281461 by krileon

Replied by krileon on topic Line 887 in cbpaidControllerUI, move div to template

Our rounded template in latest nightly release uses Bootstrap panel styling perfectly fine. I'm not familiar with UIKit, but you may want to take a look as it could be compatible just changing the classes.

Please Log in or Create an account to join the conversation.

krileon
ONLINE
Posts: 48459
Thanks: 8280
Karma: 1443

8 years 5 months ago #281467 by krileon

Replied by krileon on topic Line 887 in cbpaidControllerUI, move div to template

Reviewed UIKit and it's the same HTML structure. So in the rounded template you can certainly use panels for plan display without altering any core code. The class changes are as follows.

.panel = .uk-panel .uk-panel-box
.panel-heading = .uk-panel-title
.panel-body = REMOVE

The below color styles are conditioned in the below template files with an IF statement.

.panel-default = REMOVE
.panel-primary = .uk-panel-box-primary

This should be done in the following files.

components/com_comprofiler/plugin/user/plug_cbpaidsubscriptions/templates/rounded/productusersubscription/default.php

components/com_comprofiler/plugin/user/plug_cbpaidsubscriptions/templates/rounded/somethingusersubscription/default.php

components/com_comprofiler/plugin/user/plug_cbpaidsubscriptions/templates/rounded/productmerchandise/default.php

components/com_comprofiler/plugin/user/plug_cbpaidsubscriptions/templates/rounded/productdonation/default.php

Those files are for individual subscription, merchandise, and donation blocks.

The following user(s) said Thank You: nant

Please Log in or Create an account to join the conversation.

Moderators: beat, nant, krileon