Skip to Content Skip to Menu

🕒 Save Time and Effort with CB Editor Assistant: Effortlessly create and refine content in Joomla 3, 4, & 5.
🎁 Limited Offer: Enjoy a 5-day FREE trial and save up to 30% afterward!

empty #system-message-container

  • carin
  • carin
  • OFFLINE
  • Posts: 417
  • Thanks: 18
  • Karma: 0
7 years 11 months ago #290675 by carin
empty #system-message-container was created by carin
Why is comprofiler putting out empty #system-message-container divs? That is bad for SEO, bad for custom coding, not good for anything AFAIK.

CB 2.0

Please Log in or Create an account to join the conversation.

  • krileon
  • krileon
  • ONLINE
  • Posts: 48711
  • Thanks: 8320
  • Karma: 1447
7 years 11 months ago #290692 by krileon
Replied by krileon on topic empty #system-message-container
Joomla is entirely responsible for outputting the system message container. CB API can't even create a message queue with an empty string. Your issue has nothing to do with CB and is just how Joomla handles the message queue when the message tag is added to the Joomla template.

If you want to confirm it's entirely Joomla feel free to use Joomlas test drive demo and check there as well. You'll see it's in the DOM.

demo.joomla.org/#

That is bad for SEO, bad for custom coding, not good for anything AFAIK.

This is completely false, but if you want it improved feel free to contribute to Joomla below and change it.

github.com/joomla


Kyle (Krileon)
Community Builder Team Member
Before posting on forums: Read FAQ thoroughly + Read our Documentation + Search the forums
CB links: Documentation - Localization - CB Quickstart - CB Paid Subscriptions - Add-Ons - Forge
--
If you are a Professional, Developer, or CB Paid Subscriptions subscriber and have a support issue please always post in your respective support forums for best results!
--
If I've missed your support post with a delay of 3 days or greater and are a Professional, Developer, or CBSubs subscriber please send me a private message with your thread and will reply when possible!
--
Please note I am available Monday - Friday from 8:00 AM CST to 4:00 PM CST. I am away on weekends (Saturday and Sunday) and if I've missed your post on or before a weekend after business hours please wait for the next following business day (Monday) and will get to your issue as soon as possible, thank you.
--
My role here is to provide guidance and assistance. I cannot provide custom code for each custom requirement. Please do not inquire me about custom development.

Please Log in or Create an account to join the conversation.

  • carin
  • carin
  • OFFLINE
  • Posts: 417
  • Thanks: 18
  • Karma: 0
7 years 11 months ago #290701 by carin
Replied by carin on topic empty #system-message-container

This is completely false

According to google and the SEO experts you are wrong. They say you should not clutter the page with unnecessary code. And of course it is bad for custom coding when you have to deal with meaningless DOM elements. And what exactly is the empty div good for?

But it is indeed Joomla that puts out the empty message div. I think my cck is why it does not appear in all my other pages except the cb pages.

Thanks for the github link but I am in no way qualifyed to touch any of the core files.

The issue can be considered closed since it is not related to CB.

CB 2.0

Please Log in or Create an account to join the conversation.

  • krileon
  • krileon
  • ONLINE
  • Posts: 48711
  • Thanks: 8320
  • Karma: 1447
7 years 11 months ago #290703 by krileon
Replied by krileon on topic empty #system-message-container
It'd impact the SEO if it was piled with data that slowed the page load, but it isn't as It's an empty div. Page load does affect SEO, but again it's a single empty div in the DOM so it's not really contributing to page load time at all. I guess if you've some JS parsing through every DOM element with a weak selector usage it'd have a slight impact, but that'd just be a symptom of the JS. So yeah I guess I could be wrong depending on the situation, but as for your situation you've no reason to worry about it; you won't gain any performance removing it.

Also dug into it further. It's a problem with the template where message queue is output. The IF check is inside of the container div. The IF check just needs to be moved. More specifically see the below file for Joomlas protostar template.

templates/protostar/html/layouts/joomla/system/message.php

I'm not sure why they're doing it this way. There might be a styling reason behind it. I don't know.

Thanks for the github link but I am in no way qualifyed to touch any of the core files.

There is no qualification for contributing to Joomla. Just follow their coding standards and make a pull request. It'll be tested, reviewed, and if accepted merged.


Kyle (Krileon)
Community Builder Team Member
Before posting on forums: Read FAQ thoroughly + Read our Documentation + Search the forums
CB links: Documentation - Localization - CB Quickstart - CB Paid Subscriptions - Add-Ons - Forge
--
If you are a Professional, Developer, or CB Paid Subscriptions subscriber and have a support issue please always post in your respective support forums for best results!
--
If I've missed your support post with a delay of 3 days or greater and are a Professional, Developer, or CBSubs subscriber please send me a private message with your thread and will reply when possible!
--
Please note I am available Monday - Friday from 8:00 AM CST to 4:00 PM CST. I am away on weekends (Saturday and Sunday) and if I've missed your post on or before a weekend after business hours please wait for the next following business day (Monday) and will get to your issue as soon as possible, thank you.
--
My role here is to provide guidance and assistance. I cannot provide custom code for each custom requirement. Please do not inquire me about custom development.

Please Log in or Create an account to join the conversation.

Moderators: beatnantkrileon
Powered by Kunena Forum