CB Activity 6.x - bookmarks

Hi,

In Joomla! 3.10 the ActivityTable::isBookmarked() function does not work properly. Always returns FALSE. I didn't notice this problem in J4.

A more detailed analysis of the problem (in J3) allowed us to determine that the problem is the use of the ?? operator



Since always returns FALSE and not NULL, the value returned by has no practical significance.

As a result, you cannot delete a specific bookmark because a submenu item for this action never appears.

The same problem occurs with ActivityTable::isFollowing().

I haven't looked into it further, so perhaps I don't fully understand the intent of this solution.
However, the error is real.

Regards,[/code]

Joomla version doesn't matter for 90% of CBs code. How are you confirming it doesn't work right? It works perfectly fine in my tests.



That will return NULL if no value has been set for _bookmarked on the activity object. The purpose of this implementation is _bookmarked is a flag switch used during bookmarking and prefetching so it doesn't need to query for a state it's already aware of.

As a result, you cannot delete a specific bookmark because a submenu item for this action never appears.

This too appears to be working fine.

 

I believe you may have an issue coming from somewhere else. Maybe something is setting _bookmarked always to false for some reason? It should get set during prefetching behavior, but it certainly shouldn't always be false. The prefetcher state setting is handled by BookmarkHelper::getBookmarksByActivity. The main thing that could cause this to always be false is if the activity id doesn't exist or you've bookmarked your own post somehow, which isn't allowed and will ignore that.

I guess everything is clear now. Your tip was valuable.

BookmarkHelper::getBookmarksByActivity() 
The $id variable is of type int. The elements of the $bookmarked array are of type string.
The in_array() function uses type checking (third argument TRUE).
In this situation, in_array() always returns FALSE.

I hope my reasoning is correct.

What do you think?
Regards,
 

Depends on where the activity array comes from as $id could be a string (this is why we need generics in PHP!). It's probably only failing when querying for the activity object directly outside of a stream. Inside of a stream like shown above it's working fine. Anyway, will add some stricter type enforcement to avoid type issues there.

forge.joomlapolis.com/issues/9383

Good catch! Thank you for letting us know! Should have it fixed tomorrow. Going to go through and replace any other usages still using the array key instead of the stricter id function as well as any missing query results not being passed through int casting. Looks like this primarily only impacts bookmarks. I'm not seeing any problems with following, which strictly uses asset strings.

Ok, this is now fixed in latest CB Activity build release. Fixed all potential type juggling issues where arrays of activity rows were handled. Confirmed isBookmarked and isFollowing were working with all prefetchers and caching disabled as well. Please let me know if you're still having issues after updating.