I found this - it's not the idea fix but until other components get it correct in 1.09....
includes/frontend.php
/**
* Cache some modules information
* @return array
*/
function &initModules() {
global $database, $my, $Itemid;
if (!isset( $GLOBALS )) {
$query = "SELECT id, title, module, position, content, showtitle, params"
. "\n FROM #__modules AS m"
. "\n INNER JOIN #__modules_menu AS mm ON mm.moduleid = m.id"
. "\n WHERE m.published = 1"
. "\n AND m.access <=
'". $my->gid ."'"
. "\n AND m.client_id != 1"
. "\n AND ( mm.menuid =
'". $Itemid
."' OR mm.menuid = 0 )"
. "\n ORDER BY ordering";
$database->setQuery( $query );
$modules = $database->loadObjectList();
foreach ($modules as $module) {
$GLOBALS[$module->position][] = $module;
}
}
return $GLOBALS;
}
Quoting Stingrey:
Are there consequences to changing this part of the frontend.php in terms of security or stability?
No there is not.
The change was made to correct the value check, to ensure the correct variable type of mm.menuid
mm.menuid is an integer variable, using quotes can slow the query very very slightly as the use of quotes changes the value to a string value rather than an integer value.
However, it seems some components are not correctly returning any Itemid value, thuis resulting in the check being
mm.menuid = OR mm.menuid = 0
which causes an error in the query
The query can however handle a case where the query is
mm.menuid = '' OR mm.menuid = 0
Hope that helps
www.joomlaportal.de/215915-post28.html
forum.joomla.org/index.php/topic,67115.0.html
Post edited by: Goob, at: 2006/06/08 20:43
