email notifications

So some time ago you suggested I setup an autoaction to send notifications as emails.
I set up the following in User:
if ( ! $variables->getPublished() ) {
    return [];
}
return $variables->getRecipients();

And the trigger is:  activity_OnAfterNotificationEntityStore

It worked ok for a long while but has become increasingly sporadic, sometimes sending mails, sometimes not, sometimes sending to the group, sometimes to everyone registered...
Any ideas to make this work a bit better - the external notification thing (email, push) is just an essential for my clients. I know you're working on something.

It's only going to send a notification if CB Activity would log a notification. So there are times where it's not going to send such as duplicate notifications or notifications to people that aren't set to receive that notification. That is the only way to extend CB Activity notification behavior. I've nothing more to suggest right now beyond just making emails for specific triggers (e.g. onAfterUserRegistration, onAfterJoinGroup, etc..). The trigger is defined as follows.

It's possible you may need to check for var3 being true or 1 in your auto action conditions. This ensures it only sends an email for newly created notifications. That maybe where the sporadic behavior is coming from as it could be sending during edits. getRecipients() basically just returns a list of user ids that the notification was logged to in the _comprofiler_plugin_activity_notification database table and that's it. So if a user doesn't get your email then they never not the notification to begin with.

We won't have a universal notification system until sometime in CB 3.x. It'll be your standard notification you might of seen on other sites with the name of the notification then checkboxes for email, private message, sms, on-site, etc..

Looks like the only usecase where that trigger won't fire is if the recipients of an existing notification are being updated, but the notification itself is not updating. Will review adding a activity_onAfterNotificationEntityUpdate trigger, but you're likely to get duplicate email notifications doing that. I'll try to add to the trigger a $newRecipients variable by diffing the before and after of the added recipients to alleviate that.

Ok, this is now available in latest CB Activity build release. It's now possible to act on an existing notification getting new recipients. This behavior is common with grouped notifications like profile.%.login notifications for example. Below is the usage I'd recommend.

Global
Triggers: activity_onAfterNotificationEntityStore, activity_onAfterNotificationEntityUpdate
Type: Email
User: Code
Access: Everybody
User
The rest of your auto action should be able to remain the same. Added some logic for var3 since for Store it's going to be TRUE for a new notification otherwise FALSE if the notification itself was modified. For Update var3 will always be a recipient diff so you'll only send emails for new recipients.

Thank you - trying it out right now... I'll let you know how it goes, so far so good